jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Docker Hub now returns 401 for missing repos #1664

Closed minrk closed 1 year ago

minrk commented 1 year ago

adds a DockerRegistry.not_found_401 boolean to treat 401 as not found, in addition to 404. Only used if a token was successfully issued, which at least validates that some valid credentials are held, even if they might not have the necessary permissions for private repos.

It is now impossible to distinguish between a repo not existing and not having access to the repo on Docker Hub.

From GESIS health logs, this appears to have changed at 22:20 CEST last night, a truly wild coincidence with the readmission of GESIS to the federation earlier that day.

@rgaiacs

rgaiacs commented 1 year ago

I confirm this PR resolve fix the problem.