jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Use launch_quota.total_pods in health check #1682

Closed minrk closed 1 year ago

minrk commented 1 year ago

not deprecated pod_quota

otherwise, health check reports the wrong value unless the deprecated value is specified

manics commented 1 year ago

This failed to deploy on staging:

I haven't checked whether it's a BinderHub problem, or a mybinder config problem.

manics commented 1 year ago

It should be total_quota since LaunchQuota is platform agnostic https://github.com/jupyterhub/binderhub/blob/0c3d8b23d396f1d0d276605356c8c329b2cc1376/binderhub/quota.py#L43-L54