search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

launch_quota.total_quota #1683

Closed manics closed 1 year ago

manics commented 1 year ago

Fix for https://github.com/jupyterhub/binderhub/pull/1682#issuecomment-1530106672 (and therefore https://github.com/jupyterhub/mybinder.org-deploy/issues/2617)

This should be total_quota since LaunchQuota is platform agnostic https://github.com/jupyterhub/binderhub/blob/0c3d8b23d396f1d0d276605356c8c329b2cc1376/binderhub/quota.py#L43-L54

manics commented 1 year ago

Thanks for reviewing! The test failure is external https://github.com/jupyterhub/binderhub/issues/1687