search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

k3s latest: specify version (v1.26) #1684

Closed manics closed 1 year ago

manics commented 1 year ago

Using latest means things are liable to break when there's a new release. Although this happens infrequently when it does happen it either leads to wasted time, or PRs being merged without tests being completed.

If we want to automate the bump it could be added to the https://github.com/jupyterhub/binderhub/blob/main/.github/workflows/watch-dependencies.yaml workflow

manics commented 1 year ago

The

on:
  pull_request:
    paths-ignore:
      ...
      - "!.github/workflows/test.yml"

exclusion obviously isn't working since this workflow hasn't run on this PR

manics commented 1 year ago

Maybe exclusions can only be used with paths and not paths-ignore? https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-and-excluding-paths

Though it's still not working

manics commented 1 year ago

Yeah... I realised that eventually. I'm going to merge this so we can try and fix the other issues. Incidentally I noticed some of the tests are incorrectly passing because curl http://localhost:30901/health --max-time 5 --retry 5 --retry-delay 1 --retry-connrefused doesn't return a non-zero exit code when /heath returns a HTTP error- something to be fixed separately.