search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

test.yml: check curl status for HTTP error #1686

Closed manics closed 1 year ago

manics commented 1 year ago

By default curl doesn't return a non-zero exit code when it receives a HTTP error, e.g. even if http://binderhub/health returns a 500 error curl will exit with 0.

--fail-with-body should ensure it exits with an error code, whilst still showing the retrieved content (-f exits with an error code but doesn't display the content).

manics commented 1 year ago

It makes more sense to bundle this with https://github.com/jupyterhub/binderhub/pull/1683