jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

CI: https://doi.org/10.6084/m9.figshare.9782777.v1 is broken #1687

Closed manics closed 1 year ago

manics commented 1 year ago

Bug description

test_figshare https://doi.org/10.6084/m9.figshare.9782777.v1 is failing https://github.com/jupyterhub/binderhub/blob/d77c26a9689753fe6bad5246be57a0ee4549b997/binderhub/tests/test_repoproviders.py#LL98C14-L98C60

E.g.

=========================== short test summary info ============================
FAILED binderhub/tests/test_repoproviders.py::test_figshare[10.6084/m9.figshare.9782777.v1-10.6084/m9.figshare.9782777.v1-9782777.v1-https://doi.org/10.6084/m9.figshare.9782777.v1-figshare-9782777.v1] - tornado.httpclient.HTTPClientError: HTTP 404: Not Found
= 1 failed, 133 passed, 1 skipped, 3 deselected, 9 warnings in 147.95s (0:02:27) =
Error: Process completed with exit code 1.

https://github.com/jupyterhub/binderhub/actions/runs/4855218964/jobs/8653527069?pr=1683

Expected behaviour

Test passes

Actual behaviour

https://doi.org/10.6084/m9.figshare.9782777.v1 redirects to https://figshare.com/articles/Binder-ready_openSenseMap_Analysis/9782777/1 which doesn't exist

The correct page seems to be https://figshare.com/articles/software/Binder-ready_openSenseMap_Analysis/9782777/1

manics commented 1 year ago

Now fixed on the Figshare end.