jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Get rid of eslint GH workflow #1691

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

This is handled by prettier in the pre-commit workflow instead

manics commented 1 year ago

I thought prettier only formats code, whereas eslint also detects some likely errors?

yuvipanda commented 1 year ago

Ah whoops I had thought we were using eslint with a much more relaxed rulset, but we aren't!

https://prettier.io/docs/en/comparison.html

Code-quality rules: eg no-unused-vars, no-extra-bind, no-implicit-globals, prefer-promise-reject-errors

Prettier does nothing to help with those kind of rules. They are also the most important ones provided by linters as they are likely to catch real bugs with your code!

In other words, use Prettier for formatting and linters for catching bugs!