JS: Rename BinderImage to BinderRepository

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!

https://binderhub.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.54k stars 388 forks source link

JS: Rename BinderImage to BinderRepository #1694

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

Makes more sense, as we're representing a repository and then building it.
Moves away from this being a default export, so we could export other functions and classes in the future. This is a 'breaking' change but nobody else uses this for now.

Ref https://github.com/jupyterhub/binderhub/issues/1373

consideRatio commented 1 year ago

We have BuildExecutor Python classes doing work in the backend, is this class maybe representing an inidividual BuildExecution?

yuvipanda commented 1 year ago

@consideRatioI don't think the name here should be based on the internal details of the python backend. This class also doesn't necessarily represent a single BuildExecution as EventSource by default will retry and can make multiple connections. I think BinderRepository is the correct name here conceptually.