search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

BinderHub.build_node_selector vs KubernetesBuildExecutor.node_selector #1723

Open rgaiacs opened 1 year ago

rgaiacs commented 1 year ago

I see

[BinderHub] WARNING | BinderHub.build_node_selector is deprecated, use KubernetesBuildExecutor.node_selector

in the pod execution log but https://github.com/jupyterhub/binderhub/blob/6f03245a89c8a70e0cd5b349b384cf58e483d88a/helm-chart/binderhub/templates/container-builder/daemonset.yaml#L37 ignores KubernetesBuildExecutor.node_selector.