jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Support dynamic push credentials obtained from registry #1724

Closed manics closed 1 year ago

manics commented 1 year ago

Extracted from https://github.com/jupyterhub/binderhub/pull/1637 This is required to support time-limited registry credentials, as required by AWS ECR.

Required for https://github.com/jupyterhub/mybinder.org-deploy/issues/2629

manics commented 1 year ago

What do you think of the updated docs? I've renamed the new property.

Do you think it's worth switching to a dynamic secret instead, ~and not have a new property~ a new property is required, otherwise the secret needs to be created outside the Kubernetes builder which breaks the abstraction.

manics commented 1 year ago

Both of these environment variables are used by repo2docker:

In hindsight prefixing them with R2D_ would've been a good idea and makes sense for future additions. We could add new R2D_ env vars and check for both old and new, but that risks adding to the confusion.