search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Revert "Use URLSearchParams() to construct query strings" #1755

Closed manics closed 12 months ago

manics commented 12 months ago

Reverts jupyterhub/binderhub#1741

This code isn't tested by our CI, and resulted in a failure on mybinder.org: https://github.com/jupyterhub/binderhub/issues/1747 which now blocks further BinderHub updates.

This syntax can be seen to be invalid in a browser javascript console:

>> new URL("/" + "build/")
Uncaught TypeError: URL constructor: /build/ is not a valid URL.
yuvipanda commented 12 months ago

Ugh, I can see how this worked when I tested this locally but failed on mybinder.org :( I'll put up another change.