Split big index.js file into multiple smaller files

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!

https://binderhub.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.54k stars 388 forks source link

Closed yuvipanda closed 11 months ago

yuvipanda commented 12 months ago

Follows the plan laid out in https://github.com/jupyterhub/binderhub/issues/777
Only non-trivial move is to cleanup the _config call to use the more modern 'fetch' API rather than the older XMLHttpRequest API

A screen recording of me testing this is available in https://github.com/jupyterhub/binderhub/pull/1758

choldgraf commented 12 months ago

omg is it finally happening?!

yuvipanda commented 11 months ago

Thanks @consideRatio. I've applied your suggested changes.

I think after this gets merged, I'll enable prettier for JS in this repo as well, so that should handle all other formatting inconsistencies.

consideRatio commented 11 months ago

Wieeee thank you @yuvipanda for taking the time to this!!! :heart: :tada: