search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Add `BuildExecutor.repo2docker_extra_args` config #1766

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

Very helpful for a specific binderhub instance to customize how images are built. Off the top of my head, two useful things would be to pass --repo-dir (so you can have this work with a persistent home directory but still get access to the files in the image), and --base-image (so an install can use a different base image than rep2docker default).

As it's a simple passthrough, I've added a unit test only (no integration test).

Fixes https://github.com/jupyterhub/binderhub/issues/1765

yuvipanda commented 1 year ago

Failures are unrelated I think

consideRatio commented 1 year ago

Lgtm!

I tweaked the title to "Add repo2docker_extra_args config" as it by itself clarifies the mechanism to allow passing args and that then enables the changelog to provide a better overview. I also added the "new" label for this PR!