search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

JS & CSS: Autoformat with pre-commit & prettier #1767

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

I removed the two lines in .pre-commit-config.yaml and ran pre-commit run -all

Follow-up to https://github.com/jupyterhub/binderhub/pull/1761

consideRatio commented 1 year ago

@yuvipanda can you push the changes you make manually in a dedicated commit?

yuvipanda commented 1 year ago

@consideRatio I didn't make any manual changes here, unless you're talking about the changes to .pre-comit-ci.yaml?

yuvipanda commented 1 year ago

I edited the description to describe what I did.

yuvipanda commented 1 year ago

no idea why eslint now fails though. I'll investigate later.

yuvipanda commented 1 year ago

Given I'm making some more fixes to the JS, I'm actually going to come back to this later. I think trying to fix this right now will 100% sap the 'fix things' energy I have.