jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Make eslint understand modern .js with babel's parser #1768

Closed consideRatio closed 11 months ago

consideRatio commented 11 months ago

With this, we can use prettier in pre-commit without getting errors stemming from the formatting changes. Previously we did because the eslint's .js parser was not modern enough to support the formatting changes.

By switching to use the @babel/eslint-parser we are fine for now at least, and I think in the future as well, because we end up using a parser that is provided by babel, which is also what we use to transform the .js into something else.

yuvipanda commented 11 months ago

Thanks for sorting this out, @consideRatio