jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

JS: Refactor link & badge generation, use URLs (not string) for base URLs #1778

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

This is two changes that were easier to make together

Here is a screen recording of me testing this out. You can see url generation + badge generation work fine for a couple cases, as well as building + launching.

https://github.com/jupyterhub/binderhub/assets/30430/f9cb387c-9308-4330-86e0-9f4d82bdfd7e

Ref https://github.com/jupyterhub/binderhub/issues/774

yuvipanda commented 1 year ago

Test failures still unrelated

consideRatio commented 1 year ago

Like in https://github.com/jupyterhub/binderhub/pull/1773#issuecomment-1759728662

I think its a good call to opt for a merge at this point even though I'm not so confident reviewing this, it helps with Yuvi's contribution momentum and we aren't introducing new API or similar that we commit to long term in this PR either.

I've done my best to review this, and I think it looks good!

consideRatio commented 1 year ago

I removed tests and added maintenance. maintenance is a label respected by github-activity, while tests isn't.

yuvipanda commented 1 year ago

Thanks @consideRatio, I appreciate it! When both these PRs are merged, I'll roll them out to mybinder.org and keep an eye out.