Closed yuvipanda closed 1 year ago
Test failures still unrelated
Like in https://github.com/jupyterhub/binderhub/pull/1773#issuecomment-1759728662
I think its a good call to opt for a merge at this point even though I'm not so confident reviewing this, it helps with Yuvi's contribution momentum and we aren't introducing new API or similar that we commit to long term in this PR either.
I've done my best to review this, and I think it looks good!
I removed tests
and added maintenance
. maintenance
is a label respected by github-activity
, while tests
isn't.
Thanks @consideRatio, I appreciate it! When both these PRs are merged, I'll roll them out to mybinder.org and keep an eye out.
This is two changes that were easier to make together
@jupyterhub/binderhub-client
as it is reasonably generic and not super specific to our frontend alone. This also involves them not reading BASE_URL and BADGE_BASE_URL globally, but having that information be passed in. Tests are also added here to catch any future issues that may arise.Here is a screen recording of me testing this out. You can see url generation + badge generation work fine for a couple cases, as well as building + launching.
https://github.com/jupyterhub/binderhub/assets/30430/f9cb387c-9308-4330-86e0-9f4d82bdfd7e
Ref https://github.com/jupyterhub/binderhub/issues/774