search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

JS: Remove all references to global URL constants #1781

Closed yuvipanda closed 1 year ago

yuvipanda commented 1 year ago

Instead they are passed in wherever needed. Cleaner code, and path towards everything being more testable

Ref https://github.com/jupyterhub/binderhub/issues/774

yuvipanda commented 1 year ago

Thanks for the catch and the fix, @GeorgianaElena and @consideRatio! I've pulled, rebased and tested to make sure it works ok. I'll merge this now and deploy to mybinder.org shortly.

I'm going to hopefully add optional typechecking (no typescript) to help catch errors like this.