JS: Fix some JSDoc types, and misc details in tests

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!

https://binderhub.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.54k stars 388 forks source link

Closed yuvipanda closed 11 months ago

yuvipanda commented 11 months ago

Optional args get [] around the param name, not the type!
Remove extra increased timeout for some jest tests, as they are not needed
Pass actual URL objects to some of the methods, rather than strings. These accidentally worked but shouldn't be relied upon.
Import just the function used during tests from node modules, rather than the entire module.
Fix type of fetch to indicate that's actually just an iterator, not a generator.

consideRatio commented 11 months ago

Amazing work on this @yuvipanda !!!!