jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Add support for image pull secrets to build pod #1805

Closed sgaist closed 9 months ago

sgaist commented 9 months ago

Proposed change

Currently the build pod generated by BinderHub can only use public images to do its work which might not always be practical. My suggestion is to add support for setting image pull secrets on the KubernetesBuildExecutor so that people can make use of private registries as well.

Alternative options

The only other solution I currently see is to have a separate registry that allows access without credentials.

Who would use this feature?

People deploying BinderHub on restricted systems. For example all images have to come from a specific registry that requires authentication.

(Optional): Suggest a solution

The implementation is pretty straightforward as it requires a new configure option for the KubernetesBuildExecutor for a list of strings that will be the list of secret name and update the pod creation to include that list.