jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Remove ingress.https with unused kube-lego references, rely on ingress.tls and ingress.annotations #1813

Closed yuvipanda closed 2 months ago

yuvipanda commented 8 months ago

kube-lego was the precursor to cert-manager, and has been dead for years and years now

yuvipanda commented 8 months ago

Thanks @consideRatio.

I am going to wait to make sure I have access to the curvenote member as well (https://github.com/jupyterhub/mybinder.org-deploy/issues/2920) before merging this and deploying it on mybinder.org

yuvipanda commented 2 months ago

Closing in favor of plan in https://github.com/jupyterhub/binderhub/pull/1862#issuecomment-2197822914