Clean up when launch fails

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!

https://binderhub.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.55k stars 388 forks source link

Clean up when launch fails #245

Open yuvipanda opened 6 years ago

yuvipanda commented 6 years ago

If Binder fails to launch a JupyterHub server, it should try to explicitly stop it and not leave pods randomly lying around orphaned. https://github.com/jupyterhub/kubespawner/issues/95 is related

choldgraf commented 6 years ago

It's hard for me to tell if this is fixed now, though I'll note that we have a decent amount of failed launches, and to my knowledge this doesn't result in orphaned pods. Can we call this fixed?

minrk commented 6 years ago

I don't believe that we actively attempt top stop the server. We have gotten better at failing to proceed if the request stops, for instance, so some orphaned server cases (e.g. user disconnected before launch started) are less likely to occur now.