fix custom-header - Githubissues

jupyterhub / configurable-http-proxy

node-http-proxy plus a REST API

BSD 3-Clause "New" or "Revised" License

242 stars 130 forks source link

fix custom-header #369

Closed minrk closed 2 years ago

minrk commented 2 years ago

collector must return the result

The test was passing because the update-in-place way we implemented the collector apparently works if you have more than one header, but not if you have only one. I don't know if that's a bug upstream or not, but the right thing to do is to return after each collection.

Additional improvements:

allow colons in header values (split only on first, since colons are quite sensible in header values, e.g. host:port)
log and exit when proxy cli fails to start in tests

closes #368

Timost commented 2 years ago

LGTM ! Thank you for doing all the work ! 🙏