jupyterhub / configurable-http-proxy

node-http-proxy plus a REST API
BSD 3-Clause "New" or "Revised" License
242 stars 130 forks source link

Update to commander 9 #384

Open guimard opened 2 years ago

guimard commented 2 years ago

Hi,

for the record, here is a patch for commander 9 (used to publish configurable-http-proxy in Debian):

--- a/bin/configurable-http-proxy
+++ b/bin/configurable-http-proxy
@@ -114,6 +114,7 @@
     process.exit(1);
   }
   previous[headerParts[0]] = headerParts[1];
+  return previous;
 }

 cli.parse(process.argv);

Cheers, Yadd

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 2 years ago

Thank you @guimard! The change suggestion seems resolved and part of #369, but we still use an old version of commander, but I want to cut a release dropping support for node 10 and bumping commander to a modern version that no longer supports node 10.

consideRatio commented 2 years ago

This is described about commander 8.x.y

The current version of Commander is fully supported on Long Term Support versions of node, and requires at least node v12.

Version 9.x.y clarifies and sais node v12.20.0+ is required.