search

jupyterhub / configurable-http-proxy

node-http-proxy plus a REST API
BSD 3-Clause "New" or "Revised" License
242 stars 130 forks source link

Update to use alpine 3.16 as a base image. #415

Closed Christian-Nunnally closed 2 years ago

Christian-Nunnally commented 2 years ago

Proposed change

Alpine 3.15 has some CVE violations and should be updated to 3.16.

Alternative options

Who would use this feature?

Everyone.

(Optional): Suggest a solution

I tried to create a PR to make this small change but so not have permission in the repository. Also the contributing.MD does not exist.

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 2 years ago

@Christian-Nunnally hi! Feel free to open a PR using a branch in a "fork" of this project. You are now allowed to create branches in this github repository, but you are allowed to make a copy of it and create a pull request to your copied projects branch!

I think this guide may help with those steps: https://opensource.com/article/19/7/create-pull-request-github

Cheers!

Christian-Nunnally commented 2 years ago

@consideRatio Thank you! I was able to create a PR here: https://github.com/jupyterhub/configurable-http-proxy/pull/416

consideRatio commented 2 years ago

Closed by #416 - thanks @Christian-Nunnally!!!

Btw, if your PR description includes "closes #416" or "fixes #416", github will automatically close that associated issue when the PR is merged :)

Thanks for your contribution!!! :heart: :tada: :sunflower: You can now use version 4.5.2 of the image.