jupyterhub / firstuseauthenticator

JupyterHub Authenticator that lets users set passwords when they first log in
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

delete_user should not fail if password has not been set yet #15

Closed willirath closed 5 years ago

willirath commented 5 years ago

Currently, it is assumed that all users that are deleted are present in the dbm file:

https://github.com/jupyterhub/firstuseauthenticator/blob/master/firstuseauthenticator/firstuseauthenticator.py#L127

To also cover cases where users are deleted before they have logged in (and hence created an entry in the dbm file), I propose catching KeyErrors in delete_user.

willirath commented 5 years ago

Related: https://github.com/jupyterhub/the-littlest-jupyterhub/issues/231