Fix bug where create_users and password requirement couldn't work together

jupyterhub / firstuseauthenticator

JupyterHub Authenticator that lets users set passwords when they first log in

BSD 3-Clause "New" or "Revised" License

48 stars 31 forks source link

Fix bug where create_users and password requirement couldn't work together #33

Closed saisiddhant12 closed 3 years ago

saisiddhant12 commented 3 years ago

The detailed requirements can be found here https://github.com/jupyterhub/firstuseauthenticator/issues/32 or Issue #32

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:

saisiddhant12 commented 3 years ago

Thanks a lot for all your guidance and encouraging @GeorgianaElena This is my first PR in Jupyterhub, would love to learn and do more