search

jupyterhub / grafana-dashboards

Grafana Dashboards useful for k8s + JupyterHub
https://jupyterhub-grafana.readthedocs.io
BSD 3-Clause "New" or "Revised" License
55 stars 23 forks source link

Unused `global_dash` function parameter - let's setup pre-commit hooks #103

Closed consideRatio closed 6 months ago

consideRatio commented 7 months ago

Having an unused global_dash parameter added some confusion while doing code inspection on how to deploy the global dashboard.

I figure the fix should be to add automation to catch this with pre-commit.

consideRatio commented 6 months ago

We have removed global_dash, and we have setup pre-commit hooks.