search

jupyterhub / helm-chart

A store of Helm chart tarballs for deploying JupyterHub and BinderHub on a Kubernetes cluster
https://jupyterhub.github.io/helm-chart/
188 stars 74 forks source link

ingress: Additional property ingressClassName is not allowed #130

Closed rafagsiqueira closed 2 years ago

rafagsiqueira commented 2 years ago

Bug description

Can't set the ingressClassName for the ingress on the values.yaml.

Expected behaviour

With the deprecation of the ingress class annotation, the helm chart should accept ingressClassName as a parameter for the ingress.

Actual behaviour

Error ingress: Additional property ingressClassName is not allowed.

How to reproduce

Set: ingress: enabled: true ingressClassName: nginx on values.yaml and try do install the helm release.

Your personal set up

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 2 years ago

The jupyterhub Helm chart is maintained in jupyterhub/zero-to-jupyterhub-k8s. ingressClassName is supported, but a release has not been made to include it.