search

jupyterhub / helm-chart

A store of Helm chart tarballs for deploying JupyterHub and BinderHub on a Kubernetes cluster
https://jupyterhub.github.io/helm-chart/
188 stars 74 forks source link

jupyterhub versions in readme #94

Closed choldgraf closed 5 years ago

choldgraf commented 5 years ago

This adds a table to the readme that we can use to list important version numbers of various software in the helm chart. AFAIK, the most important thing is JupyterHub, so right now that's the only thing in there.

I'm actually not sure which versions of JupyterHub are in each helm chart so I've put XXX as a placeholder. Can somebody point me to a place where this information exists? Alternatively feel free to suggest changes to the PR to update the values! (maybe @consideRatio or @yuvipanda knows?)

ablekh commented 5 years ago

I believe that the relevant information can be extracted from Git history of the Chart.yaml file:

https://github.com/jupyterhub/zero-to-jupyterhub-k8s/commits/master/jupyterhub/Chart.yaml

Based on that, we can also update the table with two additional dependencies: K8s and Tiller.

choldgraf commented 5 years ago

For sure - once somebody adds in the proper versions, I'll make a PR to z2jh as well!

choldgraf commented 5 years ago

@yuvipanda do you know what's the easiest way I can figure out the JupyterHub versions installed in previous helm charts? I can find the hub image that's being used from the published helm chart, but I can't find the corresponding Dockerfiles for some images (e.g., where is the dockerfile for https://hub.docker.com/r/yuvipanda/jupyterhub-k8s-hub). If you give me a pointer then I can hunt down where the jupyterhub versions are

consideRatio commented 5 years ago

@choldgraf thank you for pushing this forward!! I think the easiest way is to checkout helm chart tags on z2jh and see what the image/hub/Dockerfile sais, but it will probably reference a variable for the image, set in chartpress.yaml - so checkout z2jh release tags and look in chartpress.yaml for a jhub ver!

choldgraf commented 5 years ago

@consideRatio the challenge is that (as far as I can see) the helm chart references an image, not a Dockerfile (e.g., https://github.com/jupyterhub/zero-to-jupyterhub-k8s/commit/3780008ea7af1c57d80d2a3e341260ff80991df2#diff-12954dbbf0b55794e31ac3975def3c6fL60) which makes it hard for me to find the specific version of jupyterhub that is used. Do you know how I can dig into those images to find the version of JupyterHub in there?

consideRatio commented 5 years ago

I'm quite confident that the image that is referenced, which is time cumbersome to inspect, is an image built from the Dockerfile of the related z2jh repo git tag.

I did some digging!

Version mapping

Z2JH JupyterHub
v0.1 0.7.2
v0.2 0.7.2
v0.3 0.7.2
v0.3.1 0.7.2
v0.4 0.7.2
v0.5 0.8.1
v0.6 0.8.1
0.7.0 0.9.2
0.8.0 0.9.4

Sources

consideRatio commented 5 years ago

I pushed a commit, does it look okay to you @choldgraf ?

consideRatio commented 5 years ago

I also added what I think is true for the required versions for k8s and helm as @ablekh suggested. Note that 0.8.0 doesn't require Helm 2.11 unless you activate podPriority but it does if you do, so I figure I should write it as "required" even though it is a soft requirement.

choldgraf commented 5 years ago

ahhh amazing!!! yes this looks great, thanks so much :-)

I'm happy to merge this, at which point I'll add a link to z2jh...then I think that we're ready to go on v0.8!

yuvipanda commented 5 years ago

<3 ty @consideRatio!!!!