search

jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
105 stars 101 forks source link

Tests failing #115

Open yuvipanda opened 3 weeks ago

yuvipanda commented 3 weeks ago

The image tests are failing, but the bash is too complex for me to really debug. I think it's ok for now.

manics commented 15 hours ago

I don't think it's the tests, I think there's a genuine error. A clean rebuild of main leads to the desktop failing to appear, and a Javascript error Uncaught Error: Cannot find module '@novnc/novnc/core/rfb'

manics commented 15 hours ago

Hmmm.... maybe there are multiple errors, https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/120 is still failing

consideRatio commented 15 hours ago

Did a new version of websockify arrive 1 month ago perhaps? Tests fail when websockify is involved, but for both tiger and turbovnc, and in a test without this project proxying things involved.

manics commented 7 hours ago

I've removed websockify: https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/119