jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
113 stars 105 forks source link

Sets static port for vnc (fixes #47) #52

Closed domna closed 1 year ago

domna commented 1 year ago

Not using the static port breaks the image, rendering it unusable. This essentially reverts commit https://github.com/jupyterhub/jupyter-remote-desktop-proxy/commit/447bf86d66bced05e5a02160f2eb5c0739994b68 to fix this

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on this branch for commit c782eb963ce8067be8f3278525157ca4fa5dce22

I will automatically update this comment whenever this PR is modified

yuvipanda commented 1 year ago

Opened https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/53 instead