Stop vendoring noVNC

[yuvipanda]

We have been vendoring noVNC to get vnc_lite.html, maintaining a patch file so we could upgrade the version of noVNC used if needed.

noVNC publishes a JS library onnpm that we can easily use instead, and stop vendoring the whole package! This brings us the following massive advantages:

1. No more vendoring an entire package in!
2. Upgrades of noVNC client become practically trivial
3. We can change the frontend as we wish much more easily, compared to having to maintain a patch file as we do now. PRs like https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/7 become easier.
4. There's also some possible licensing issues around us vendoring this anyway https://github.com/jupyterhub/jupyter-remote-desktop-proxy/issues/27#issuecomment-1737925373, this will get rid of that

This PR:

• Adds a package.json to include the noVNC js package
• Adds a webpack.config.js to provide JS bundling, so we can just ship a single viewer.js file that has everything.
• Adds appropriate bits (stolen and adapted from jupyterhub's config) to package the built JS in the final wheel as necessary.
• Upgrade from noVNC 1.2 to 1.4, but otherwise keep everything the same. I just copied our patched vnc_lite.html into index.html, and just split out the JS / CSS. I also changed the title of the page
• prettier with pre-commit has done its thing on the JS, CSS and HTML. This is fine, as I am hoping we can make more changes to the UI after this.
• Modify the Dockerfile to setup the conda env first, and then separately install the python package with pip. This makes local development much faster.
• Add a .gitignore (which this repo was missing), with node_modules included as well as the dist/ directory with the built JS.
• Add a test to make sure the built JS is included in the sdist and bdist
• Add a test to make sure the built container image has the built JS

[github-actions[bot]]

:point_left: Launch a binder notebook on this branch for commit a59abc47f79bda12c9d7f98c403830ee9cb7759f

I will automatically update this comment whenever this PR is modified

:point_left: Launch a binder notebook on this branch for commit 823b155e3b86484a0c25ae329842677b5102def4

:point_left: Launch a binder notebook on this branch for commit 68e25d07d088eb40b16f4b6dbd866727d6e52b5a

:point_left: Launch a binder notebook on this branch for commit 3a6e81e59912a4b3f67a32c725dfe721b9a97b28

:point_left: Launch a binder notebook on this branch for commit 296f78196ad72d5ea853e2d38b488bd5540add44

:point_left: Launch a binder notebook on this branch for commit 704151c03fc5969ea071bae190e492d99568fc85

:point_left: Launch a binder notebook on this branch for commit 7ac5182c66a0b0de01419be0154dc6336a3871d8

:point_left: Launch a binder notebook on this branch for commit 0ba06897707e62e6ebf25f56da082b9211697bb6

:point_left: Launch a binder notebook on this branch for commit cfb1a14a3e472ca3c977872145638a5299e92d56

[yuvipanda]

mmmmmmmmmmm love it

[yuvipanda]

Once this gets merged, I'll cleanup the JS file a little and implement a version of #7

[yuvipanda]

https://github.com/novnc/noVNC/blob/master/docs/API.md there's also a bunch of stuff we can do to make the experience better, like automatic reconnects, sending resize events through, save screenshots, etc.

[manics]

The desktop fails to load on mybinder: Loading failed for the <script> with source “https://notebooks.gesis.org/binder/jupyter/user/jupyterhub-jupy-e-desktop-proxy-rk6lnz86/desktop/dist/viewer.js”.

[yuvipanda]

@manics ah interesting, it works for me locally in a container. wonder why. I'll dig through and see.

[yuvipanda]

I can reproduce the failure on mybinder! Shall test.

[yuvipanda]

Interesting, but it works on a JupyterHub!

[yuvipanda]

(base) jovyan@jupyter-jupyterhub-2djupy-2de-2ddesktop-2dproxy-2d85ah8316:~$ ls /opt/conda/lib/python3.11/site-packages/jupyter_remote_desktop_proxy/static/
clipboard.svg  index.css  index.html

Alright, this is something about how the image is being built.

[yuvipanda]

@manics it works now!

[yuvipanda]

I'm going to add a quick test to make sure that the wheel and sdist have the built files too

[yuvipanda]

Cleaning up some JS on top in https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/78

[yuvipanda]

yay thank you @manics! Take a look at the other PRs too when you get a minute :D When done, I'll make a release.