search

jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
116 stars 106 forks source link

Automatically reconnect if we lose connection #81

Closed yuvipanda closed 6 months ago

yuvipanda commented 10 months ago

This needs much better retry logic, with back-offs and status messages. But fundamentally, it does already work \o/

Fixes https://github.com/jupyterhub/jupyter-remote-desktop-proxy/issues/80

github-actions[bot] commented 10 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 27f67ce831e01eac905f5336ae9cb2f599a63679

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit fab710e8e25271ec545cc435a345b2e0b5000cb2

consideRatio commented 9 months ago

Excited about this bugfix! I think it would mean that a restart of for example a ingress-nginx or jupyterhub proxy pod would be handled more gracefully.

consideRatio commented 8 months ago

This needs much better retry logic, with back-offs and status messages.

I'll see if I can get this worked to completion before tuesday. The goal I have made explicit: to provide retry logic with backoff, verify function manually by changing network rules on the fly.

consideRatio commented 8 months ago

I attempted for an hour or so but failed to make progress =/

yuvipanda commented 6 months ago

Superceeded by https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/112