jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
105 stars 101 forks source link

Remove bundled VNC server #84

Closed manics closed 4 months ago

manics commented 5 months ago

Fixes https://github.com/jupyterhub/jupyter-remote-desktop-proxy/issues/27 (incorrect licensing, noarch metadata doesn't match bundled executable in pypi package)

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 25da12636bd2634e3c57226bbfe9e64aade4bcb3

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 94cf5b636de529f376e36f473908474d54f8bc05

Binder :point_left: Launch a binder notebook on this branch for commit 2c210fe966eeeaeb8b7ba3e2827683cdf7d29001

consideRatio commented 5 months ago

Amazing work on things @yuvipanda and @manics!!!

I've not reviewed the changed lines in the PR but I think this is a good decision!

yuvipanda commented 4 months ago

@manics I've pushed a change with suggested new wording. If this looks good to you, I think we should merge and make a release!