Publish TigerVNC and TurboVNC image to quay.io

jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub

BSD 3-Clause "New" or "Revised" License

105 stars 101 forks source link

Publish TigerVNC and TurboVNC image to quay.io #94

Closed consideRatio closed 4 months ago

consideRatio commented 4 months ago

This PR updates the Dockerfile so that it can build to include TigerVNC (default) or TurboVNC by passing --build-arg vncserver=turbovnc. It then automates a build and publishing of an image in two variants:

quay.io/jupyterhub/jupyter-remote-desktop-proxy:<version> (the same as -tigervnc)
quay.io/jupyterhub/jupyter-remote-desktop-proxy:<version>-tigervnc
quay.io/jupyterhub/jupyter-remote-desktop-proxy:<version>-turbovnc
Fixes #88 Provides multi arch images, Amd64 and Arm64
Fixes #68 In a very primitive way though, where I think #93 improves on testing beyond this basic check

github-actions[bot] commented 4 months ago

:point_left: Launch a binder notebook on this branch for commit 93a203bed7ac03fe0dcd1e9810ed67aee5851ce2

I will automatically update this comment whenever this PR is modified

:point_left: Launch a binder notebook on this branch for commit a8f8d5148ce67c891f5959281c27a5052f31b2d5

:point_left: Launch a binder notebook on this branch for commit 3b8ebd5a2b0eecccee2e5db6414db13dc59dbc5e

:point_left: Launch a binder notebook on this branch for commit 5fcb6bd7199e733683c68a2f12f526085563c3d8

:point_left: Launch a binder notebook on this branch for commit 88421591b0cf53df098afe900e421bc38663bb94

consideRatio commented 4 months ago

The suffix functionality is now available in v3 of action-major-minor-tag-calculator, making this expected to work in order to publish with and without the suffixes -tigervnc and -turbovnc.

I'll go for a merge!