search

jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
105 stars 101 forks source link

Fix failure to specify port for TurboVNC server #99

Closed consideRatio closed 3 months ago

consideRatio commented 3 months ago

Without specifying a port for TurboVNC, we will fail to wrap it I think. jupyter-server-proxy will proxy to the port websockify listens to, and websockify is configure to listen to {port} correctly, but I think this port must be the same what is to be wrapped - otherwise it won't wrap that specific bind I think. Note that all examples include specifying websockify port for the wrapped command as well (or know it and match it without specifying it to match).

With this, things work - without it it doesn't for TurboVNC.

Debugged in https://github.com/jupyterhub/jupyter-remote-desktop-proxy/issues/98#issuecomment-1985044545. I've tested this to resolve #54 manually.

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 024414efd33950c25ff200a02e1c0d75553e918b

I will automatically update this comment whenever this PR is modified