search

jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Rewrite /auth-sign-in redirect. #108

Closed ryanlovett closed 2 years ago

ryanlovett commented 2 years ago

This depends on https://github.com/jupyterhub/jupyter-server-proxy/pull/300 and is intended to fix #97.

It also removes the version environment variable and detection function. If/when this is merged we can bump the version dependency.

garyburgmann commented 2 years ago

@ryanlovett I can confirm that this solution is working for us (we are simply mirroring your branches):

https://gitlab.com/ecocommons-australia/ecocommons-platform/analysis-playground-notebooks/-/blob/fa33d9ff7714a05449e70c1a4c13a5ee1743374b/r-base/Dockerfile#L66

image

Thank you!

ryanlovett commented 2 years ago

@garyburgmann Thanks for checking, it works on mybinder and a local hub too. Its the worst-case solution, though it might not be how things are solved in the end.

ryanlovett commented 2 years ago

I'm closing this in favor of another that is based on the latest changes to jupyter-server-proxy.

garyburgmann commented 2 years ago

@ryanlovett are you able to elaborate on the other other preferred solution that was used?

ryanlovett commented 2 years ago

@garyburgmann Yes, please see #110. I guess I should have just folded my newer branch's changes into this one.

garyburgmann commented 2 years ago

thanks for that @ryanlovett