jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Malformed URL at binder with urlpath=rstudio #114

Closed ryanlovett closed 2 years ago

ryanlovett commented 2 years ago

Bug description

The latest version at mybinder.org works, unless one sets urlpath=rstudio. It causes the binder URL to have a path of /user/reponame/rstudio?token={token}/auth-sign-in... which results in a 502 HTTP error. Rather than concatenate the /auth-sign-in portion to the request uri, we need to parse the latter and append the Location header value to just the path and not the whole uri.

Expected behaviour

You set urlpath=rstudio at mybinder.org rather than launch Jupyter Lab and then start RStudio.

Actual behaviour

Jupyter produces an http error.