search

jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Fix server data dir (/var/run/rstudio) not writable. Support multiple rstudio-server versions #119

Closed ccoulombe closed 2 years ago

ccoulombe commented 2 years ago

By default, the option --set-data-dir points to /var/run/rstudio which is not writable other then by sudo. Set the option to a temporary directory.

Support multiple rstudio-server versions, from v1.2.1335 and up

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

ryanlovett commented 2 years ago

Thanks for this @ccoulombe ! In a similar PR, #118, I suggested it'd be better to create the data dir outside of db_config() and then pass the directory in as a parameter. I think this is more logical since the data dir is used for things other than the db. For example, something like this.

I like expanding the rserver parameters when they're supported by the help text.

ccoulombe commented 2 years ago

@ryanlovett I'll update according to your comments in the PR.

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

ryanlovett commented 2 years ago

Thanks again @ccoulombe ! Sorry for the delay -- I had missed that you updated the PR.