Open ryanlovett opened 2 years ago
ryanlovett
commented
2 years ago @yuvipanda suggested on slack:
[let's] make it a configurable and default to base_url/logout when we know we are on a hub [...] so if people are running it without a hub that has functional logout (like mybinder!) they can do something else
riazarbi
commented
2 years ago +1 for configurability.
Best for our use case would be to redirect to /hub/home so that a user
can kill the server. We don’t really have much use for logging out, but
quite often our users will get the environment into a bad state and need to
kill their container.
So allowing us to configure this would be awesome.
On Mon, 17 Jan 2022 at 05:43, Ryan Lovett @.***> wrote:
@yuvipanda https://github.com/yuvipanda suggested on slack:
[let's] make it a configurable and default to base_url/logout when we know we are on a hub [...] so if people are running it without a hub that has functional logout (like mybinder!) they can do something else
— Reply to this email directly, view it on GitHub https://github.com/jupyterhub/jupyter-rsession-proxy/issues/122#issuecomment-1014111731, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGPYN44QEU37LSTQ5GRSFDUWOF4XANCNFSM5MBPSYAQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
When someone clicks the sign-out button, next to the rstudio quit button at the top right, the user receives a
locationin the response headers of /user/soandso/rstudio/auth-sign-out/auth-sign-in. Since the user gets logged out of rstudio, they receive a 401, and the body contains onlyUnauthorized.If a user is on a hub with rstudio, I think the expected behavior of clicking this button is to initiate the hub sign-out process. So when the proxy sees /auth-sign-out/auth-sign-in in the response header, it should replace the value with /user/soandso/logout.