jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

base_url not set #123

Closed guimou closed 2 years ago

guimou commented 2 years ago

Hi!

Bug description

The base_url variable used to set --www-root-path (L93 of _init.py) is not replaced by any value. If I test it in a standalone mode of JupyterLab, I end up with the command .... --www-root-path={base_url}rstudio/ ... exactly as written in the script, no variable substitution. Same thing behing with JupyterHub behind a Reverse Proxy (although here I have other issues with the auth-sign-in rewrite, but this must be related). Trying to debug it, base_url is indeed an unknown variable from Python's point of view. As per jupyter-server-proxy documentation, this variable should be replaced.

Expected behaviour

Variable set correctly.

Your personal set up

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

guimou commented 2 years ago

Wrong diagnosis on my part, I was not debugging at the right place. Problem solved with the solution provided by #124 (and comments in #121).