jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Increase start timeout #127

Closed matuskosut closed 1 year ago

matuskosut commented 2 years ago

Proposed change

Increase start timeout from default 5s to higher value, or at least allow to override using ENV variable.

If I am correct this might be affected https://jupyter-server-proxy.readthedocs.io/en/latest/server-process.html#timeout

Alternative options

Who would use this feature?

it would help those who experience timeout error due to slow start of rsession

timeout

(Optional): Suggest a solution

small draft how this could work, including environment variable that could be used to override default timeout:

    default_timeout = 15
    try:
        timeout = int(os.getenv('RSESSION_TIMEOUT', default_timeout))
    except Exception:
        timeout = default_timeout
    return {
        'command': _get_cmd,
        'timeout': timeout,
        'environment': _get_env,
        'launcher_entry': {
            'title': 'RStudio',
            'icon_path': get_icon_path()
        }
    }

something like this should then be add in these parts:

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: