search

jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Configuration variable precedence #6

Closed ianabc closed 7 years ago

ianabc commented 7 years ago

Where should configuration changes for the RSessionContext configurables path, cmd and env go? I tried c.RSessionContext.env in jupyter_notebook_config.py but that seemed to be ignored.

ryanlovett commented 7 years ago

Yes, sorry. That is how I intended config to function, but since this extension isn't a NotebookApp it doesn't read the config file. If I merge #7 then all of this goes away. Otherwise I'll probably use the tornado settings mechanism to read the config. I'll make a choice shortly.

ianabc commented 7 years ago

Hi Ryan perfect, thank you. I'm working with @cmd-ntrf on some of the same systems and we're using his modifications now and it is indeed working for us. I think the only configurable he has left is RSessionContext.cmd. Feel free to close this if you want.

ryanlovett commented 7 years ago

The config is now auto-detected directly from R which is what rserver does.