jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Option to set "reconnect false;" for shiny apps #72

Closed vnijs closed 4 years ago

vnijs commented 4 years ago

shiny-server has a configuration option called reconnect (see https://community.rstudio.com/t/app-feature-works-on-shinyapps-io-but-not-with-shiny-server-pro/36285/3). Is there an option to set this to false for Shiny apps launched using the Shiny icon via jupyter-rsession-proxy?

Related question: Does jupyter have a similar reconnect option to shiny-server I could turn off as shiny apps launched from Rstudio through jupyterlab seem to mess up the same feature mentioned in the post above.

ryanlovett commented 4 years ago

This extension doesn't let you alter the shiny-server configuration except for a few parameters, though it could be extended to do so.

According to the docs, reconnect can be specified in local app configurations, but that would require adding allow_app_override in the global config. That makes sense for this extension and would be straightforward to add.

Not sure about the latter issue.

vnijs commented 4 years ago

Thanks for the response @ryanlovett. I ended up using the source from the 1.0b6 build because I couldn't get the source from master to work with my docker container. I made a few changes and they (mostly) work as intended. See link below:

https://github.com/vnijs/jupyter-rsession-proxy/blob/master/jupyter_rsession_proxy/__init__.py

The one weird thing I still get is that my shiny app "hangs" on browser refresh in Rstudio-server when started from jupyterlab. Works fine with RStudio-server called directly. If you have any ideas/suggestions on what might be going on I'd love to hear them. Else, feel free to close this issue.

ryanlovett commented 4 years ago

Okay, thanks. Please open a new issue for the hanging problem if you'd like. It'd be good to include any javascript console errors your browser reports.