jupyterhub / jupyter-rsession-proxy

Jupyter extensions for running an RStudio rsession proxy
BSD 3-Clause "New" or "Revised" License
118 stars 87 forks source link

Use tmp file for secure cookie #98

Closed danielfrg closed 2 years ago

danielfrg commented 3 years ago

Updating https://github.com/jupyterhub/jupyter-rsession-proxy/pull/94 to master so we can get it merged.

This is needed to support multiple RStudio Sessions in the same machine.

The actual changes are very little there are other linting changes that happened automatically because of my VS Code setup, I can remove those if needed but hopefully its ok :D

The actual changes are:

def _get_cmd(port):
        ntf = tempfile.NamedTemporaryFile()
        cmd = [
            get_rstudio_executable("rserver"),
            "--auth-none=1",
            "--www-frame-origin=same",
            "--www-port=" + str(port),
            "--www-verify-user-agent=0",
            "--secure-cookie-key-file=" + ntf.name,
        ]
welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

danielfrg commented 2 years ago

I updated the branch to master. @ryanlovett would you be able to take a look at this?

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

ryanlovett commented 2 years ago

Lgtm. Thanks for your patience @danielfrg !

danielfrg commented 2 years ago

Thanks for merging!