Add JupyterLab 4 support for the extension

jupyterhub / jupyter-server-proxy

Jupyter notebook server extension to proxy web services.

https://jupyter-server-proxy.readthedocs.io

BSD 3-Clause "New" or "Revised" License

351 stars 148 forks source link

Add JupyterLab 4 support for the extension #419

Closed trungleduc closed 1 year ago

trungleduc commented 1 year ago

Add JupyterLab 4 support for the extension.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

bollwyvl commented 1 year ago

If this is worth doing (and it probably is) it should also support Notebook 7, to the best of its abilities. As NB7 doesn't have a launcher, it would need to be ported to a file browser dropdown to stay consistent, UX-wise.

There is some work on-going to update documentation for supporting lab4/nb7 in the same extension, which can likely be used here: basically checking whether ILabShell is available should be enough.

Much as I tried (admittedly, not very hard), I ended up not being able to cleanly do keyword-for-keyword compatibility between jquery- and lumino-based notebooks, so the browser-based acceptance tests would need to updated to use the new client keywords.

trungleduc commented 1 year ago

Indeed It would be nice to support both Lab 4 and Notebook 7, but I think It can be addressed in a separate PR.

trungleduc commented 1 year ago

Hi @ryanlovett @takluyver @consideRatio @yuvipanda, can someone take a look at this PR? Thanks!

ryanlovett commented 1 year ago

Hi @trungleduc, I do think it'd be wonderful to support JL4, but I'm afraid the javascript bits are not my strong suit.

To me it seems fine to add support for Notebook 7 in a separate PR given that it has a different launch mechanism. I imagine this could be the New menu in the file browser as it was in previous notebook versions, or something new.

Khagesh16 commented 1 year ago

Really appreciate jlab 4 upgrade

consideRatio commented 1 year ago

I pushed a commit commenting yarn configs and fixed details in a README file
Tests failures are unrelated, tracked in https://github.com/jupyterhub/jupyter-server-proxy/issues/421.
I opened #420 to track additional work to make this software provide a Notebook 7 compatible frontend extension as well.

Thank you for working this @trungleduc!!

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: