jupyterhub / jupyter-server-proxy

Jupyter notebook server extension to proxy web services.
https://jupyter-server-proxy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
347 stars 148 forks source link

List tornado and traitlets as dependencies explicitly, and cleanup unreachable code #457

Closed consideRatio closed 6 months ago

consideRatio commented 6 months ago

We reference tornado and traitlets directly from our source code, so we should surface those dependecies.

We require jupyter-server>=1.0, which depend on tornado>=5.0 and traitlets>=4.2.1, so I'm adding our dependency on tornado and traitlets explicitly in this project, putting their lower bounds to those versions - and adding a test to verify our test suite works against those versions.

For reference, note that jupyter-server==1.1.0 released four years ago requires tornado 6.1, so I figure its safe to assume we can bump these notably without issues in the future.


This enables me to better reason about https://github.com/jupyterhub/jupyter-server-proxy/pull/448, as its changing something that is passed to tornado, and tornado's behavior may differ slightly between versions.