jupyterhub / jupyter-server-proxy

Jupyter notebook server extension to proxy web services.
https://jupyter-server-proxy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
354 stars 147 forks source link

Require at least tornado 6.1 - a dependency for notebook 6.2+ and jupyterlab 3+ #466

Closed consideRatio closed 7 months ago

consideRatio commented 7 months ago

We are meant to test our oldest supported dependencies, but adding the test was done incorrectly so it wasn't tested. When I'm fixing that bug, I note that testing our oldest deps fails because of installing transient dependencies not supporting tornado 5.1.

I think we should bump to require tornado 6.1 as we are supposed to be used with jupyterlab 3.0.0 or notebook<7, so for example notebook 6.x. If we assume jupyterlab 3, we need tornado 6.1. If we assume notebook 6.2+, we need tornado 6.1 - so requiring tornado 6.1 should be fine right?