search

jupyterhub / jupyter-server-proxy

Jupyter notebook server extension to proxy web services.
https://jupyter-server-proxy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
347 stars 148 forks source link

`new_browser_tab` is True by default, but documented to be False #469

Closed ryanlovett closed 5 months ago

ryanlovett commented 5 months ago

The docs for new_browser_tab say:

JupyterLab only - True if the proxied server URL should be opened in a new browser tab. False (default) if the proxied server URL should be opened in a new JupyterLab tab.

However, the default is actually True.

There was discussion of this in #198 where the conclusion was to set it to be True by default. (even though the issue title states it should be False)

So I think this just needs to be fixed in the docs.