search

jupyterhub / jupyter-server-proxy

Jupyter notebook server extension to proxy web services.
https://jupyter-server-proxy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
354 stars 147 forks source link

Responsive Proxy for other Stream Types #502

Open jwindgassen opened 2 months ago

jwindgassen commented 2 months ago

With #479, there is now support for proxying a text/event-stream, but not any other stream type (video/data). From what I can tell, this was originally not possible because of the way RewritableResponse works.

But with the new Stream Support, I don't see RewritableResponse used anywhere in the new implementation. Furthermore, the reference implementation ideonate/jhsingle-native-proxy/jhsingle_native_proxy/proxyhandlers.py#L249 has no restriction to the stream type and just exposes this as a configurable flag.

So is there still any reason we currently only support text/event-stream, or could this be expanded?

jwindgassen commented 1 month ago

Hey @yuvipanda and @ganisback

As you were responsible for integrating this feature, I was hoping you might be able to give some more details about this issue.